Dhruv - labs 1 and 2 #86
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RCMast3r
requested changes
Sep 16, 2024
dhruv/lab1p2/include/hello_world.hpp
Outdated
dhruv/lab1p2/src/hello_world.cpp
Outdated
| @@ -0,0 +1,6 @@ | |||
| #include <iostream> | |||
| #include "hello_world.hpp" | |||
There was a problem hiding this comment.
prefer includes using <> instead of ""
dhruv/lab1p2/src/main.cpp
Outdated
| @@ -0,0 +1,8 @@ | |||
| #include "hello_world.hpp" | |||
There was a problem hiding this comment.
see comment about include directive
dhruv/lab2p1/result
Outdated
There was a problem hiding this comment.
please dont push up your result symlink
dhruv/lab2p1/src/hello_world.cpp
Outdated
| @@ -0,0 +1,6 @@ | |||
| #include <iostream> | |||
| #include "hello_world.hpp" | |||
There was a problem hiding this comment.
see comment about includes
dhruv/lab2p1/src/main.cpp
Outdated
| @@ -0,0 +1,9 @@ | |||
| #include <iostream> | |||
| #include "hello_world.hpp" | |||
There was a problem hiding this comment.
see comment about includes
| @@ -0,0 +1,6 @@ | |||
| #include <hellolib.hpp> | |||
dhruv/lab2p2/result
Outdated
There was a problem hiding this comment.
see comment about including this file
dhruv/lab2p3/result
Outdated
There was a problem hiding this comment.
see comment about including this file
RCMast3r
requested changes
Sep 19, 2024
Comment on lines
+1
to
+2
| #ifndef HelloWorld | ||
| #define HelloWorld |
There was a problem hiding this comment.
by convention these are supposed to be all caps
There was a problem hiding this comment.
please use the top-level .gitignore
Comment on lines
+1
to
+2
| #ifndef HelloWorld | ||
| #define HelloWorld |
There was a problem hiding this comment.
pls use top-level .gitignore
Comment on lines
+1
to
+2
| #ifndef HelloWorld | ||
| #define HelloWorld |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.