Update sensor.py #244
Closed
Update sensor.py #244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iMicknl
reviewed
Aug 13, 2023
|
So has my request here been rejected or accepted? I still feel that adding the measurement sensor state class is a useful change, but it doesn't appear to be in the beta branch yet. Apologies if this is in progress and I'm looking in the wrong place, I'm still getting to know GitHub. |
|
Sorry, @AzimuthMiridian, this one slipped my mind. Happy to accept your contribution indeed! Would it be possible for you to rebase on beta branch? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added sensor state class of "measurement" to the Nest Protect temperature sensor definition, so that HA recognizes and collects min/mean/max statistical information for these sensors. Doing so also allows the temperature sensors to be used in HA statistics graphs.