-
-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check cookies function #282
base: beta
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I won't merge it directly, but will make sure this is part of the V2 release. Will need to do some testing myself first.
Would you be willing to also improve the instructions in the README (or in the Config Flow).
I have now tried to update the instructions on how to retrieve issue_token and cookies. Furthermore I added a description to the account selection step. I do not have a Mac available, so I cannot check the findings reported there. Regarding issueToken and oauth2/iframe (last entry) finding the same request: I do see this, but only if there was a session already. If clearing cookies or using Incognito it is two different requests. Therefore I kept this. |
An attempt to implement the suggested check of the cookies string.
It checks if there are other cookies than the five I saw using the incognito mode. It seems when doing it from a normal tab where cache was not properly cleared there are more, or at least could very well be.
It is merely a warning. Users may choose to continue anyway.
You may use it, or choose not to.
Just my two cents.