Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check cookies function #282

Open
wants to merge 7 commits into
base: beta
Choose a base branch
from
Open

Check cookies function #282

wants to merge 7 commits into from

Conversation

jnxxx
Copy link

@jnxxx jnxxx commented Dec 16, 2023

An attempt to implement the suggested check of the cookies string.
It checks if there are other cookies than the five I saw using the incognito mode. It seems when doing it from a normal tab where cache was not properly cleared there are more, or at least could very well be.
It is merely a warning. Users may choose to continue anyway.

You may use it, or choose not to.
Just my two cents.

@jnxxx jnxxx requested a review from iMicknl as a code owner December 16, 2023 14:16
Copy link
Owner

@iMicknl iMicknl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I won't merge it directly, but will make sure this is part of the V2 release. Will need to do some testing myself first.

Would you be willing to also improve the instructions in the README (or in the Config Flow).

@jnxxx
Copy link
Author

jnxxx commented Dec 17, 2023

I have now tried to update the instructions on how to retrieve issue_token and cookies.
It is mainly incorporation of #272, and a bit of formatting and checking menu names etc.

Furthermore I added a description to the account selection step.
I am not really sure myself, but seems to be production and test. So, basically saying to use the default one.
The link in the second step is fine (points to beta branch though).

I do not have a Mac available, so I cannot check the findings reported there.
The menu layout could be different and searching in dev. tools, but the core browser functionality should hopefully be the same.

Regarding issueToken and oauth2/iframe (last entry) finding the same request: I do see this, but only if there was a session already. If clearing cookies or using Incognito it is two different requests. Therefore I kept this.
The issueToken request gets the same cookies as input/request, but updates one of them which can be found under response. Rather than user having to merge request and response cookies, oauth2/iframe (last entry) finds the subsequent request where most recent cookies can be found under request cookies.
Based on my own experience, I would just recommend using Incognito now there is a description on how to work around the third-party cookie issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants