Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecation fixes #300

Merged
merged 3 commits into from
Jan 16, 2024
Merged

deprecation fixes #300

merged 3 commits into from
Jan 16, 2024

Conversation

bmos
Copy link
Contributor

@bmos bmos commented Jan 16, 2024

TEMP_CELSIUS is deprecated and due to be removed next year in favor of UnitOfTemperature.CELSIUS.

loop is deprecated in favor of event_loop which causes a warning when running pytest. unrelated, but figured it should be fixed.

Closes issue #290
Replaces PR #293

@bmos bmos requested a review from iMicknl as a code owner January 16, 2024 01:31
@bmos bmos changed the base branch from main to beta January 16, 2024 01:32
@bmos
Copy link
Contributor Author

bmos commented Jan 16, 2024

passed all CI checks! 🥳

Copy link
Owner

@iMicknl iMicknl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for your contribution(s)!!

@iMicknl iMicknl merged commit dceef80 into iMicknl:beta Jan 16, 2024
2 checks passed
@bmos bmos deleted the patch-1 branch January 16, 2024 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants