-
-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve Performance and Simplify Xaml Resources #22
Comments
by using this tool this kind of refrences will be gone and we dont need them anymore
|
Sorry, I can't rly understand what u said. Could you be more specific? Will this tool cause any extra references? |
This is a msbuild tasks so there is no dll or dependency. XAMLTools.MSBuild Combines multiple XAML files to one large file. Currently, you are referencing converters and styles in each resource dictionary And you also reference the resource dictionaries as a MergedDictionary. We can delete all dictionaries and references, this tool can help us read all xaml files exist in our repo and make a single xaml file which contains all our resources/styles this way app will be run faster and style loading will be improved |
Some dictionaries are dynamically called, like Btw how will it change the project structure? |
Schema will be excluded from merging in a single file. we only merge styles and custom controls and other stuffs like converters... otherwise we should use a list of exclude options... |
Pls wait for me to re-organize the Modern.Controls library structure, then you can have a try |
Tnx |
I think it's wiser to keepn the current folder structure. Can you do that with the folder structure unchanged? |
yes, no problem |
@NotYoojun I was able to successfully merge the resources😁 FontIcon.cs -- also we can use like this:
|
Okay I've merged it |
i created a pr #27 which covers iNKORE.UI.WPF.Modern, and i am waiting for you to re-organize iNKORE.UI.WPF.Modern.Controls |
Hey @ghost1372 ,I think the current structure of iNKORE.UI.WPF.Modern.Controls is okay and I'm not gonna touch it. You can start it any minute you want. |
This issue only occurs only when the config is set to |
@NotYoojun i dont know why but changing refrence to CombinedResources.xaml fixed bug. |
I strongly suggest that you merge the libraries into a Single Library |
Thank you so much for working with us these days. So sorry that these don't work. I hope we can collaborate more in the future! |
Thank you I enjoyed it during this time👌 |
we can improve Performance and simplify Xaml Resources, I did this for HandyControl and it can improves performance and simplify development and xaml resources.
in WPF We must have only one resource file (containing all resources a single very very large file), otherwise we will suffer from performance loss. Since it is very difficult to develop the app in only one xaml file, we use MergedDictionary and seperated files.
But what if we use separate files but collect them all in one file? In this case, we have made the development process easier and improved the performance.
we can use a tool called: XAMLTools.MSBuild
if you want I can do this and collect all the resources in one file. for this we need to move xaml files in one places, so project structure will be change
let me know if you are agree or not
The text was updated successfully, but these errors were encountered: