Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporary Fix #29

Closed
wants to merge 1 commit into from
Closed

Temporary Fix #29

wants to merge 1 commit into from

Conversation

ghost1372
Copy link
Contributor

@ghost1372 ghost1372 commented Dec 1, 2023

temporary fix

@ghost1372 ghost1372 changed the title Fix Temporary Fix Dec 1, 2023
@NotYoojun
Copy link
Member

So you just use the CombinedResource as a merged dictionary in the other dictionaries. I don't think this is a good solution cause it will make the CombinedResources loaded multiple times.

@ghost1372
Copy link
Contributor Author

So you just use the CombinedResource as a merged dictionary in the other dictionaries. I don't think this is a good solution cause it will make the CombinedResources loaded multiple times.

Yes this is not a good idea, i wonder why referencing single style not working.

With this condition, you have 2 ways, either ignore this feature and revert the commits.
Or merge both libraries into one library.
I try to implement the second way to see its effects.

I am sorry for what happened

@NotYoojun
Copy link
Member

What about applying XAMLTools to the iNKORE.UI.WPF.Modern.Controls library?

@ghost1372
Copy link
Contributor Author

What about applying XAMLTools to the iNKORE.UI.WPF.Modern.Controls library?

It should work, I will test as soon as I get home

@ghost1372
Copy link
Contributor Author

ghost1372 commented Dec 2, 2023

What about applying XAMLTools to the iNKORE.UI.WPF.Modern.Controls library?

You mean we use XamlTools only for iNKORE.UI.WPF.Modern.Controls and not iNKORE.UI.WPF.Modern ??
Or you mean XamlTools for both? Because i tested for both and not worked.

@NotYoojun
Copy link
Member

I mean for both.
If that still happens, I guess I have to revert those changes 😭😭

@ghost1372
Copy link
Contributor Author

I mean for both.
If that still happens, I guess I have to revert those changes 😭😭

Yes unfortunately

@NotYoojun NotYoojun closed this Dec 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants