setting scope (and attributes) of validate_hostname #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… of `validate_hostname`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for providing this useful library.
We would like to use it at part of our web server (ref: h2o/h2o#875), but we do not like having
validate_hostnameas an extern function, since users of the web server as a library may have a function with the same name already defined.To accommodate the issue, this PR adds a macro named
OPENSSL_HOSTNAME_VALIDATION_LINKAGEthat can be used to set the scope as well as other attributes to the function. The default is set toextern, so it does not break existing code.FWIW, we are going to use it like h2o/h2o@d08e9bc.