Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[next] Upgrade peerDependencies to support material-ui v5 #355

Closed
ApacheEx opened this issue Feb 25, 2021 · 2 comments
Closed

[next] Upgrade peerDependencies to support material-ui v5 #355

ApacheEx opened this issue Feb 25, 2021 · 2 comments

Comments

@ApacheEx
Copy link

ApacheEx commented Feb 25, 2021 •
edited
Loading

Expected Behavior

when I run npm install notistack@next in project where I have @material-ui/core@next installed I should not see any errors.

Current Behavior

image

Steps to Reproduce

simply install dependency:

  • npm i @material-ui/core@next
  • npm i notistack@next

Your Environment

  • node: v15.10.0
  • npm: 7.5.3

Solution

update package.json + regenerate package-lock.json
image

p.s thanks for really awesome project. I love it.
iamhosseindhv added a commit that referenced this issue Feb 28, 2021
@iamhosseindhv
Fixes #355 - Update MUI peer dependency to next
8595890
@iamhosseindhv
Copy link
Owner

Thanks for reporting. Please update your notistack to next / notistack@1.0.6-alpha.0

@lcdss
Copy link

lcdss commented Apr 19, 2021

Thanks for reporting. Please update your notistack to next / notistack@1.0.6-alpha.0

npm i notistack@next add ^1.0.6-alpha.0 to composer.json, and after the 1.0.6 release, if you run npm update it'll give you an error as the 1.0.6 doesn't allow Material UI V5.

iamhosseindhv added a commit that referenced this issue Sep 26, 2021
@iamhosseindhv @joemaffei @ramosbugs
Publish MUI v5 compatibility as stable release (#437)
2160b28 
* Closes #334 #333 - Fix collapse keys

* 1.0.3-alpha.0

* 1.0.4-alpha.0

* 1.0.6-alpha.0

* Fixes #355 - Update MUI peer dependency to next

* 1.0.6-next.0

* Use root classKey for Collapse

* 1.0.6-next.1

* Add support for Material-UI v5 beta (#418)

* upgrade to material-ui v5; modify code as recommended by the material-ui docs

* upgrade to material-ui v5; modify code as recommended by the material-ui docs

* add missing anchor classes to SnackbarItem; fix child class declarations

* update dependencies; run build

* package-lock update

* Allow passing classes from props

* Adapt new MUI breakpoints

* Bind this

* Mark emotion peerDeps as optional

* 1.0.6-next.2

Co-authored-by: Hossein Dehnokhalaji <hossein.dehnavi98@yahoo.com>

* Support @mui/material package naming (#423)

* Support Material-UI 5.0.0-rc.0

* Bump version to 1.0.6-next.3

* Remove @mui/styles dependency

* Prepare next to be published as latest (#436)

* Add tag for people on mui-v4

* Update simple example

* Update simple example

* Update redux example

* Update mobx example

* Minor

* Update next --> latest in example codes

* Update docs

* Update CHANGELOG

* Update MUI v5 peerDependencies

* Update version to v2.0.2

* Update docs.json

Co-authored-by: Joe Maffei <joemaffei@users.noreply.github.com>
Co-authored-by: David Ramos <ramos@cs.stanford.edu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ApacheEx @lcdss @iamhosseindhv