Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix content color for dark theme #241

Merged

Conversation

iinitz
Copy link
Contributor

@iinitz iinitz commented Mar 23, 2020

fix the content color when using a dark theme

Before:
image

After
image

@animaonline
Copy link

Any updates on this one?

@iamhosseindhv
Copy link
Owner

Sorry for the tardiness. I'd appreciate if we could have a reproduction example here.

@iinitz
Copy link
Contributor Author

iinitz commented May 7, 2020

I provide type: dark in theme provider following docs

You can try to enable dark theme in material-ui doc and click show success snackbar

iamhosseindhv added a commit that referenced this pull request May 8, 2020
@iamhosseindhv iamhosseindhv merged commit 08b6541 into iamhosseindhv:master May 8, 2020
@iamhosseindhv
Copy link
Owner

Thanks for your contribution @iinitz

@AdamHsu2501
Copy link

Hi, I using dark theme of Material UI v4.10.2, How to set up words color to white?
未命名

@iinitz
Copy link
Contributor Author

iinitz commented Jun 16, 2020

Hi, I using dark theme of Material UI v4.10.2, How to set up words color to white?
未命名

Material-UI docs v4.9.14 using old version of notistack (before merged this pr) and docs v4.10.2 using latest version

Please check your notistack is latest version 😄

@iinitz iinitz deleted the fix-dark-mode-content-color branch June 16, 2020 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants