Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes casing for en-SG locale name. #1048

Merged
merged 2 commits into from
Sep 28, 2020
Merged

Fixes casing for en-SG locale name. #1048

merged 2 commits into from
Sep 28, 2020

Conversation

tarasbobak
Copy link
Contributor

In order to simplify the way consumer can work with locales programmatically it is better to unify all the locale names to single format.

All other locales are lower case, only Singapore is en-SG

@codecov
Copy link

codecov bot commented Sep 14, 2020

Codecov Report

Merging #1048 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##               dev     #1048   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          172       172           
  Lines         1522      1546   +24     
  Branches       321       328    +7     
=========================================
+ Hits          1522      1546   +24     
Impacted Files Coverage Δ
src/locale/en-sg.js 100.00% <ø> (ø)
src/index.js 100.00% <0.00%> (ø)
src/locale/bi.js 100.00% <0.00%> (ø)
src/plugin/utc/index.js 100.00% <0.00%> (ø)
src/plugin/timezone/index.js 100.00% <0.00%> (ø)
src/plugin/advancedFormat/index.js 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cf8b6a0...416bb02. Read the comment docs.

@iamkun
Copy link
Owner

iamkun commented Sep 17, 2020

we also have to update the filename accordingly.

@iamkun iamkun merged commit 2edaddc into iamkun:dev Sep 28, 2020
@iamkun
Copy link
Owner

iamkun commented Sep 28, 2020

This is somehow a breaking change. Let's make it to 1.9.0

iamkun pushed a commit that referenced this pull request Sep 28, 2020
# [1.9.0](v1.8.36...v1.9.0) (2020-09-28)

### Bug Fixes

* Add `setDefault` typing to timezone.d.ts ([#1057](#1057)) ([c0f0886](c0f0886))
* fix DST bug in utc plugin ([#1053](#1053)) ([3d73543](3d73543))
* Fix optional type for timezone plugin ([#1081](#1081)) ([a6ebcf2](a6ebcf2)), closes [#1079](#1079)
* Fix timezone plugin conversion bug ([#1073](#1073)) ([16816a3](16816a3))
* update duration plugin type file ([#1065](#1065)) ([94af9af](94af9af))
* update timezone plugin to support getting offset name e.g. EST ([#1069](#1069)) ([cbb755e](cbb755e))
* update utc plugin to support keepLocalTime `.utc(true)` ([#1080](#1080)) ([5ce4e0d](5ce4e0d))

### Features

* Correct casing for en-sg locale name ([#1048](#1048)) ([2edaddc](2edaddc))
@iamkun
Copy link
Owner

iamkun commented Sep 28, 2020

🎉 This PR is included in version 1.9.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

andrewhood125ruhuc added a commit to andrewhood125ruhuc/SidRH2 that referenced this pull request May 10, 2022
# [1.9.0](iamkun/dayjs@v1.8.36...v1.9.0) (2020-09-28)

### Bug Fixes

* Add `setDefault` typing to timezone.d.ts ([#1057](iamkun/dayjs#1057)) ([c0f0886](iamkun/dayjs@c0f0886))
* fix DST bug in utc plugin ([#1053](iamkun/dayjs#1053)) ([3d73543](iamkun/dayjs@3d73543))
* Fix optional type for timezone plugin ([#1081](iamkun/dayjs#1081)) ([a6ebcf2](iamkun/dayjs@a6ebcf2)), closes [#1079](iamkun/dayjs#1079)
* Fix timezone plugin conversion bug ([#1073](iamkun/dayjs#1073)) ([16816a3](iamkun/dayjs@16816a3))
* update duration plugin type file ([#1065](iamkun/dayjs#1065)) ([94af9af](iamkun/dayjs@94af9af))
* update timezone plugin to support getting offset name e.g. EST ([#1069](iamkun/dayjs#1069)) ([cbb755e](iamkun/dayjs@cbb755e))
* update utc plugin to support keepLocalTime `.utc(true)` ([#1080](iamkun/dayjs#1080)) ([5ce4e0d](iamkun/dayjs@5ce4e0d))

### Features

* Correct casing for en-sg locale name ([#1048](iamkun/dayjs#1048)) ([2edaddc](iamkun/dayjs@2edaddc))
andrewhood125ruhuc added a commit to andrewhood125ruhuc/SidRH2 that referenced this pull request May 10, 2022
# [1.9.0](iamkun/dayjs@v1.8.36...v1.9.0) (2020-09-28)

### Bug Fixes

* Add `setDefault` typing to timezone.d.ts ([#1057](iamkun/dayjs#1057)) ([c0f0886](iamkun/dayjs@c0f0886))
* fix DST bug in utc plugin ([#1053](iamkun/dayjs#1053)) ([3d73543](iamkun/dayjs@3d73543))
* Fix optional type for timezone plugin ([#1081](iamkun/dayjs#1081)) ([a6ebcf2](iamkun/dayjs@a6ebcf2)), closes [#1079](iamkun/dayjs#1079)
* Fix timezone plugin conversion bug ([#1073](iamkun/dayjs#1073)) ([16816a3](iamkun/dayjs@16816a3))
* update duration plugin type file ([#1065](iamkun/dayjs#1065)) ([94af9af](iamkun/dayjs@94af9af))
* update timezone plugin to support getting offset name e.g. EST ([#1069](iamkun/dayjs#1069)) ([cbb755e](iamkun/dayjs@cbb755e))
* update utc plugin to support keepLocalTime `.utc(true)` ([#1080](iamkun/dayjs#1080)) ([5ce4e0d](iamkun/dayjs@5ce4e0d))

### Features

* Correct casing for en-sg locale name ([#1048](iamkun/dayjs#1048)) ([2edaddc](iamkun/dayjs@2edaddc))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants