Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add LocalizableFormat plugin supplying format options known from Moment.js #305

Merged
merged 13 commits into from
Feb 2, 2019

Conversation

prantlf
Copy link
Contributor

@prantlf prantlf commented Aug 16, 2018

High-level options L LT LTS ... can be configured to patterns comprised of low-level options h m y ... in the formats object in a locale definition.

Default format options are English defined in the plugin source code. German localization overrides them accordingly.

It is not grammatically correct. The current localization support in Day.js
is insufficient for fusional languages like Slavic ones.
…t.js

High-level options `L LT LTS ...` can be configured to patterns comprised
of low-level options `h m y ...` in the `formats` object in a locale
definition.
@codecov-io
Copy link

codecov-io commented Aug 16, 2018

Codecov Report

Merging #305 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #305   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          52     54    +2     
  Lines         467    481   +14     
  Branches       72     75    +3     
=====================================
+ Hits          467    481   +14
Impacted Files Coverage Δ
src/locale/th.js 100% <ø> (ø) ⬆️
src/locale/ka.js 100% <ø> (ø) ⬆️
src/locale/fa.js 100% <ø> (ø) ⬆️
src/locale/sv.js 100% <ø> (ø) ⬆️
src/locale/tr.js 100% <ø> (ø) ⬆️
src/locale/zh-tw.js 100% <ø> (ø) ⬆️
src/locale/da.js 100% <ø> (ø) ⬆️
src/locale/nl.js 100% <ø> (ø) ⬆️
src/locale/nb.js 100% <ø> (ø) ⬆️
src/locale/de.js 100% <ø> (ø) ⬆️
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c4ff46f...79cc033. Read the comment docs.

Follow usage of US English in Day's.
@prantlf prantlf changed the title Add LocalisableFormat plugin supplying format options known from Moment.js Add LocalizableFormat plugin supplying format options known from Moment.js Sep 12, 2018
@iamkun iamkun added the next release Will merge into next release label Jan 14, 2019
@tcrands
Copy link
Contributor

tcrands commented Jan 29, 2019

@prantlf @iamkun I notice this hasn't been worked on for a while but has recently been tagged for next release. Are there plans for this to go in soon? Currently migrating a project away from moment and this would be very useful.

@iamkun
Copy link
Owner

iamkun commented Jan 29, 2019

@tcrands will be available in next release soon.

@iamkun iamkun merged commit 7287cdb into iamkun:master Feb 2, 2019
@iamkun
Copy link
Owner

iamkun commented Feb 2, 2019

🎉 This PR is included in version 1.8.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@iamkun iamkun added the released label Feb 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
next release Will merge into next release released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants