Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improving pt-br locale #628

Merged
merged 5 commits into from
Jul 13, 2019
Merged

Improving pt-br locale #628

merged 5 commits into from
Jul 13, 2019

Conversation

rn4n
Copy link
Contributor

@rn4n rn4n commented Jul 11, 2019

Hello ✋

Just adding the some properties to pt-br locale:

  • weekdaysMin
  • weekStart

@rn4n rn4n changed the title Add weekdays short for portuguese (br) locale. Add short weekdays for portuguese (br) locale. Jul 11, 2019
@codecov-io
Copy link

codecov-io commented Jul 11, 2019

Codecov Report

Merging #628 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@         Coverage Diff         @@
##            dev   #628   +/-   ##
===================================
  Coverage   100%   100%           
===================================
  Files       154    154           
  Lines       986    986           
  Branches    141    141           
===================================
  Hits        986    986
Impacted Files Coverage Δ
src/locale/pt-br.js 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ac2ec77...5fcfc02. Read the comment docs.

src/locale/pt-br.js Outdated Show resolved Hide resolved
@rn4n
Copy link
Contributor Author

rn4n commented Jul 12, 2019

@iamkun all this properties from moment works on dayjs?
If yes, can I add all that properties to update our portuguese locale?

@iamkun
Copy link
Owner

iamkun commented Jul 12, 2019

yes you can see all the supported properties in our locale doc.

@rn4n rn4n changed the title Add short weekdays for portuguese (br) locale. Improving pt-br locale Jul 12, 2019
@rn4n
Copy link
Contributor Author

rn4n commented Jul 12, 2019

@iamkun nice.
I've added weekStart and monthsShort too.

src/locale/pt-br.js Outdated Show resolved Hide resolved
@rn4n
Copy link
Contributor Author

rn4n commented Jul 12, 2019

Also removed weekdaysShort, the documentation says it use the first three letters.

@iamkun iamkun merged commit ccf596d into iamkun:dev Jul 13, 2019
@rn4n rn4n deleted the ptbr/weekdays_short branch July 19, 2019 13:06
iamkun pushed a commit that referenced this pull request Aug 27, 2019
## [1.8.16](v1.8.15...v1.8.16) (2019-08-27)

### Bug Fixes

* Fix relativeTime Plugin .FromNow() result error in UTC mode ([a385d5c](a385d5c))
* Handle locale in WeekOfYear plugin ([#658](#658)) ([0e45b0a](0e45b0a))
* LocaleData plugin returns all months and weekdays data when pas no argument ([#645](#645)) ([95e70b4](95e70b4))
* Return null in toJSON if not valid ([#633](#633)) ([19affc8](19affc8))
* Update Danish (da) locale ([#626](#626)) ([ac2ec77](ac2ec77))
* Update Korean locale meridiem ([#642](#642)) ([b457146](b457146))
* update Occitan locale Catalan locale ([#630](#630)) ([fef135e](fef135e))
* update pt-br locale ([#628](#628)) ([ccf596d](ccf596d))
* Update weekdaysShort to some locale files ([#643](#643)) ([cc1f15f](cc1f15f))
@iamkun
Copy link
Owner

iamkun commented Aug 27, 2019

🎉 This PR is included in version 1.8.16 🎉

The release is available on:

Your semantic-release bot 📦🚀

andrewhood125ruhuc added a commit to andrewhood125ruhuc/SidRH2 that referenced this pull request May 10, 2022
## [1.8.16](iamkun/dayjs@v1.8.15...v1.8.16) (2019-08-27)

### Bug Fixes

* Fix relativeTime Plugin .FromNow() result error in UTC mode ([a385d5c](iamkun/dayjs@a385d5c))
* Handle locale in WeekOfYear plugin ([#658](iamkun/dayjs#658)) ([0e45b0a](iamkun/dayjs@0e45b0a))
* LocaleData plugin returns all months and weekdays data when pas no argument ([#645](iamkun/dayjs#645)) ([95e70b4](iamkun/dayjs@95e70b4))
* Return null in toJSON if not valid ([#633](iamkun/dayjs#633)) ([19affc8](iamkun/dayjs@19affc8))
* Update Danish (da) locale ([#626](iamkun/dayjs#626)) ([ac2ec77](iamkun/dayjs@ac2ec77))
* Update Korean locale meridiem ([#642](iamkun/dayjs#642)) ([b457146](iamkun/dayjs@b457146))
* update Occitan locale Catalan locale ([#630](iamkun/dayjs#630)) ([fef135e](iamkun/dayjs@fef135e))
* update pt-br locale ([#628](iamkun/dayjs#628)) ([ccf596d](iamkun/dayjs@ccf596d))
* Update weekdaysShort to some locale files ([#643](iamkun/dayjs#643)) ([cc1f15f](iamkun/dayjs@cc1f15f))
andrewhood125ruhuc added a commit to andrewhood125ruhuc/SidRH2 that referenced this pull request May 10, 2022
## [1.8.16](iamkun/dayjs@v1.8.15...v1.8.16) (2019-08-27)

### Bug Fixes

* Fix relativeTime Plugin .FromNow() result error in UTC mode ([a385d5c](iamkun/dayjs@a385d5c))
* Handle locale in WeekOfYear plugin ([#658](iamkun/dayjs#658)) ([0e45b0a](iamkun/dayjs@0e45b0a))
* LocaleData plugin returns all months and weekdays data when pas no argument ([#645](iamkun/dayjs#645)) ([95e70b4](iamkun/dayjs@95e70b4))
* Return null in toJSON if not valid ([#633](iamkun/dayjs#633)) ([19affc8](iamkun/dayjs@19affc8))
* Update Danish (da) locale ([#626](iamkun/dayjs#626)) ([ac2ec77](iamkun/dayjs@ac2ec77))
* Update Korean locale meridiem ([#642](iamkun/dayjs#642)) ([b457146](iamkun/dayjs@b457146))
* update Occitan locale Catalan locale ([#630](iamkun/dayjs#630)) ([fef135e](iamkun/dayjs@fef135e))
* update pt-br locale ([#628](iamkun/dayjs#628)) ([ccf596d](iamkun/dayjs@ccf596d))
* Update weekdaysShort to some locale files ([#643](iamkun/dayjs#643)) ([cc1f15f](iamkun/dayjs@cc1f15f))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants