Fix Toggle Positioning and Add Win Popup in Tic Tac Toe #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@TornovDutta is attempting to deploy a commit to the iamparas0's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
@iamparas0 |
|
This is PR of #79 |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@iamparas0 |
|
@iamparas0 , is this PR okay? |
|
@iamparas0 please label it , and the pr |
|
@iamparas0 please check the PR |
There's a conflicting with existing code so wait I am resolving it and will merge it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses two issues in the Tic Tac Toe application: the positioning of the toggle switch and the implementation of a popup message that appears when a player wins. The CSS for the .toggle class has been updated to position it on the right side of the screen, enhancing accessibility. Additionally, a popup has been added to display the winner's name upon winning, improving user interaction. The toggle switch's position has been verified across different screen sizes, and the functionality of both the toggle and popup have been confirmed to work seamlessly.