Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

draft: Feat virtual template #12

Merged
merged 11 commits into from
Nov 5, 2023
Merged

draft: Feat virtual template #12

merged 11 commits into from
Nov 5, 2023

Conversation

iamspark1e
Copy link
Owner

relative issue: vitejs/vite#9662

code that break virtual entry: https://github.com/vitejs/vite/blob/23ef8a1a7abdb4a7e0400d7dd6ad3f7d444c548f/packages/vite/src/node/plugins/html.ts#L307

if the entry is end with ".html", html plugin will convert it to relative path no matter it is virtual module or not.

…ould not resolve virtual entry format, received incorrect relative path
@iamspark1e iamspark1e added the help wanted Extra attention is needed label Oct 7, 2023
@codecov
Copy link

codecov bot commented Oct 17, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Files Coverage Δ
index.ts 89.52% <100.00%> (+2.85%) ⬆️
src/dev-middleware.ts 95.60% <100.00%> (+0.31%) ⬆️
tests/experimental-server.test.ts 100.00% <100.00%> (ø)
tests/server.test.ts 100.00% <100.00%> (ø)
src/template.ts 91.81% <98.93%> (+1.67%) ⬆️

📢 Thoughts on this report? Let us know!.

@iamspark1e iamspark1e marked this pull request as ready for review October 17, 2023 09:31
@iamspark1e iamspark1e added enhancement New feature or request and removed help wanted Extra attention is needed labels Oct 17, 2023
@iamspark1e iamspark1e merged commit bbca257 into main Nov 5, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant