oem-ibm: Change in hb_predictive_mem_guard bios attribute #612
+20
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit enhances the displayName and helpText of hb_predictive_mem_guard and hb_predictive_mem_guard_current bios enum attribute. Signed-off-by: Riya Dixit <riyadixitagra@gmail.com>
ArchanaKakani
approved these changes
Sep 20, 2024
jaypadath
suggested changes
Sep 20, 2024
| @@ -64,15 +64,15 @@ | |||
| "attribute_name": "hb_predictive_mem_guard", | |||
| "possible_values": ["Enabled", "Disabled"], | |||
| "default_values": ["Enabled"], | |||
| "helpText": "Enable or Disable Predictive Guard for Memory Errors.", | |||
| "displayName": "Predictive Memory Guard" | |||
| "helpText": "The Hypervisor dynamically removes memory pages from memory that detected predictive failures. If this option is disabled, dynamic memory deallocation will not occur for the predictive memory failures.", | |||
There was a problem hiding this comment.
Would it be better to write "The hypervisor dynamically removes the memory pages which were identified as predictive failures" ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit enhances the displayName and helpText of hb_predictive_mem_guard and hb_predictive_mem_guard_current bios enum attribute.