Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop adding j9jit29 when the target CPU is aarch64 #126

Merged
merged 1 commit into from
Feb 14, 2019
Merged

Stop adding j9jit29 when the target CPU is aarch64 #126

merged 1 commit into from
Feb 14, 2019

Conversation

knn-k
Copy link
Contributor

@knn-k knn-k commented Feb 6, 2019

This commit stops adding j9jit29 to java.base shlibs when the target
CPU is aarch64.
This is a temporary change until the JIT library for aarch64 becomes
available.

Signed-off-by: knn-k konno@jp.ibm.com

@knn-k
Stop adding j9jit29 when the target CPU is aarch64
fd5cc89 
This commit stops adding j9jit29 to java.base shlibs when the target
CPU is aarch64.
This is a temporary change until the JIT library for aarch64 becomes
available.

Signed-off-by: knn-k <konno@jp.ibm.com>
@knn-k
Copy link
Contributor Author

knn-k commented Feb 6, 2019

Build of libj9jit29.so is blocked by the change in runtime/compiler/module.xml in eclipse-openj9/openj9#4447.

@pshipton
Copy link
Member

jenkins compile zlinux

@keithc-ca
Copy link
Member

I'd prefer to see a workaround in openj9 to produce a (stub?) j9jit. Have you explored that approach?

@knn-k
Copy link
Contributor Author

knn-k commented Feb 13, 2019 •
edited
Loading

Development of aarch64 JIT is ongoing, but it will take a while.
I think removing j9jit29 from the aarch64 build is the fastest way to make the aarch64 runtime (interpreter only) automatically buildable, because this approach changes only one file and it can be reverted easily when the aarch64 JIT is ready.

@keithc-ca
Copy link
Member

I had hoped that having a stub JIT would be a smaller request, but perhaps I was just being naive.

Removing the JIT like this is likely to cause a number of tests to fail due the warning message about a missing JIT. Please confirm you're ok with that and I will merge this.

@knn-k
Copy link
Contributor Author

knn-k commented Feb 14, 2019

I accept the failures that would be caused by missing JIT compiler.
I would like this to be merged. Thanks.

@pshipton pshipton merged commit 763ab93 into ibmruntimes:openj9 Feb 14, 2019
@knn-k knn-k deleted the aarch64build2 branch February 18, 2019 01:15
@knn-k knn-k mentioned this pull request May 22, 2019
Open
@knn-k knn-k mentioned this pull request Jun 24, 2019
Merged
knn-k added a commit to knn-k/openj9-openjdk-jdk11 that referenced this pull request Jun 27, 2019
@knn-k
Put AArch64 j9jit29 back in java.base
e42558b 
This commit stops excluding j9jit29 in java.base when the target CPU is
aarch64.  It is to revert the temporary change in ibmruntimes#126.

Signed-off-by: knn-k <konno@jp.ibm.com>
@knn-k knn-k mentioned this pull request Jun 27, 2019
Merged
hangshao0 pushed a commit to hangshao0/openj9-openjdk-jdk11 that referenced this pull request Aug 7, 2019
@keithc-ca
Merge pull request ibmruntimes#126 from runtimes/revert-90-openj9-jdk
2ec7ca6 
Revert "Fix race condition in jdwp"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pshipton pshipton pshipton approved these changes

@keithc-ca keithc-ca Awaiting requested review from keithc-ca

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@knn-k @pshipton @keithc-ca