Fix duplicate calls of mainStorage.lock() in LockManager for version 1.* #165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- store the storage lock in class LockEntry rather than in class SingleLock, - as a consequence: obtain only one storage lock when mutliple shared locks are requested on the same dataset, - release the storage lock when the lock count drops to zero, e.g. when the last lock on the dataset is closed.
|
Note: the CI build and test pipeline fails. But that looks like the icat-ansible ceased to support the old Java version used to build v1.*. The test succeed when I run them locally. |
GonozalIX
approved these changes
Jun 10, 2024
GonozalIX
approved these changes
Jul 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #164 for
ids.serverversion 1.*.