Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up BlackBear tests to remove usage of deprecated syntax #318

Open
bwspenc opened this issue Nov 21, 2022 · 0 comments · May be fixed by #322
Open

Clean up BlackBear tests to remove usage of deprecated syntax #318

bwspenc opened this issue Nov 21, 2022 · 0 comments · May be fixed by #322

Comments

@bwspenc
Copy link
Collaborator

bwspenc commented Nov 21, 2022

Reason

We have a number of tests currently failing the deprecated tests. Update the syntax of those tests, and for the syntax in BlackBear, remove the deprecated syntax since it has been deprecated for some time now.

Design

Specific usages to be addressed include:
In the concrete model:
thermal_conductivity_model and thermal_capacity_model should be replaced with thermal_model
ref_density_of_concrete should be replaced with ref_density
ref_specific_heat_of_concrete should be replaced with ref_specific_heat
ref_thermal_conductivity_of_concrete should be replaced with ref_thermal_conductivity
aggregate_vol_fraction needs to be specified with the new syntax
moisture_diffusivity_model should be replaced with moisture_model
General:
Putting block in GlobalParams gives a deprecated error
coord_type needs to go in Mesh instead of Problem
component should not be specified in Pressure BCs
MultiAppCommandLineControl is replaced by MultiAppSamplerControl

Impact

Updating the syntax in the tests will have no impact on existing behavior. Removing the outdated syntax that is in the scope of BlackBear will affect end users.
bwspenc added a commit to bwspenc/blackbear that referenced this issue Nov 21, 2022
@bwspenc
Remove deprecated syntax in tests ref idaholab#318
2f518b6
@bwspenc bwspenc mentioned this issue Nov 21, 2022
Merged
vprithiv pushed a commit to vprithiv/blackbear that referenced this issue Dec 14, 2022
@bwspenc @vprithiv
Remove deprecated syntax in tests ref idaholab#318
fe3aa90
@bwspenc bwspenc mentioned this issue Dec 21, 2022
Closed
bwspenc added a commit to bwspenc/blackbear that referenced this issue Dec 21, 2022
@bwspenc
Update concrete assessment cases after removing deprecated syntax ref i…
e2301b7 
…daholab#318

A recent change removed usage of deprecated syntax in these tests.
This resulted in an unexpected change in the model behavior because
of a memory access bug that was only triggered by the old syntax.
This updates the gold results for the Wald block tests.

The newer results show greater expansion than before, but the difference
is minor, and in many cases gives better agreement with experimental
results.
bwspenc added a commit to bwspenc/blackbear that referenced this issue Dec 21, 2022
@bwspenc
Remove deprecated syntax in ConcreteThermalMoisture closes idaholab#318
b43b388
@bwspenc bwspenc linked a pull request Dec 21, 2022 that will close this issue
Open
bwspenc added a commit to bwspenc/blackbear that referenced this issue Feb 21, 2023
@bwspenc
Remove deprecated syntax in ConcreteThermalMoisture closes idaholab#318
17a30b8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove deprecated syntax in ConcreteThermalMoisture bwspenc/blackbear
1 participant
@bwspenc