Renaming PorousMediaBase to ConcreteThermalMoisture and correcting its functions #208
Conversation
jain651
force-pushed
the
fixing_PorousMediaBase_v2
branch
from
0ed4b6a
to
cdd0985
Compare
|
Job Precheck on 96e40fe wanted to post the following: Your code requires style changes. A patch was auto generated and copied here
Alternatively, with your repository up to date and in the top level of your repository:
|
Change removal date to a date in the future and adjust the warning message to call MooseWarning()
bwspenc
force-pushed
the
fixing_PorousMediaBase_v2
branch
from
96e40fe
to
3d90cb5
Compare
| @@ -0,0 +1,18 @@ | |||
| <!-- MOOSE Documentation Stub: Remove this when content is added. --> | |||
There was a problem hiding this comment.
Ordinarily, I wouldn't want to merge new code in with a stub like this, but since you have the other PR up that adds this documentation, it's OK. You'll need to revise the other PR to modify this file rather than the old one.
| if (T < 20.0) | ||
| _thermal_conductivity[qp] = _input_thermal_conductivity_of_concrete; | ||
| else if (T >= 20.0 && T < 293.0) | ||
| if (T < 293.0) |
There was a problem hiding this comment.
This sounds suspiciously like 20 C in Kelvin. Can you please verify that T in the formula is supposed to be in Celsius rather than Kelvin?
|
Let's still investigate that issue that I pointed out, but that is tangential to the current set of changes. I'm going ahead and merging. |
closes #205