Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Damage Plasticity Model #394

Merged
merged 7 commits into from
Aug 1, 2024
Merged

Damage Plasticity Model #394

merged 7 commits into from
Aug 1, 2024

Conversation

vprithiv
Copy link
Collaborator

@vprithiv vprithiv commented Jul 3, 2024

ref #184

The initial implementation of the damaged plasticity model showed promise for modeling graphite tests but exhibited several discrepancies compared to behaviors documented in the literature (Lee and Fenves, 1998). This PR addresses these issues by thoroughly reviewing and comparing the BlackBear implementation with the published formulation and making necessary corrections and improvements.

Changes Made

  1. Decoupled the calculations of the elastoplastic response and the damage response.
  2. Implemented undamaged strength functions and their derivatives.
  3. Modified the definitions of key constants.
  4. Corrected the implementation of the plastic consistency parameter.
  5. Amended the inaccurate assignment of strength quantity in the yield function equation.

These modifications have resulted in a more accurate and reliable model.

@vprithiv vprithiv marked this pull request as ready for review July 3, 2024 15:23
@moosebuild
Copy link

moosebuild commented Jul 3, 2024

Job Documentation on 6e45724 wanted to post the following:

View the site here

This comment will be updated on new commits.

@moosebuild
Copy link

moosebuild commented Jul 3, 2024

Job Coverage on 6e45724 wanted to post the following:

Coverage

61ffc4 #394 6e4572
Total Total +/- New
Rate 93.76% 93.70% -0.06% 96.47%
Hits 1908 1904 -4 82
Misses 127 128 +1 3

Diff coverage report

Full coverage report

This comment will be updated on new commits.

Copy link
Collaborator

@bwspenc bwspenc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few minor things

src/materials/DamagePlasticityStressUpdate.C Outdated Show resolved Hide resolved
src/materials/DamagePlasticityStressUpdate.C Outdated Show resolved Hide resolved
src/materials/DamagePlasticityStressUpdate.C Outdated Show resolved Hide resolved
src/materials/DamagePlasticityStressUpdate.C Outdated Show resolved Hide resolved
src/materials/DamagePlasticityStressUpdate.C Outdated Show resolved Hide resolved
Copy link
Collaborator

@bwspenc bwspenc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks! Just a few minor changes that need to be made in the documentation page.

src/materials/DamagePlasticityStressUpdate.C Outdated Show resolved Hide resolved
@moosebuild
Copy link

Job Precheck on a8919b1 wanted to post the following:

Your code requires style changes.

A patch was auto generated and copied here
You can directly apply the patch by running, in the top level of your repository:

curl -s https://mooseframework.inl.gov/blackbear/docs/PRs/394/clang_format/style.patch | git apply -v

Alternatively, with your repository up to date and in the top level of your repository:

git clang-format 61ffc4aa3036c02e665d0b2d5fb7f3b24f7dc359

@bwspenc
Copy link
Collaborator

bwspenc commented Aug 1, 2024

@vprithiv I just pushed an update that addresses the few minor remaining issues. Assuming the tests pass I'll merge this once they pass.

@bwspenc bwspenc merged commit 0fab91b into idaholab:devel Aug 1, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants