Revert "Condensed eigen system refactor" #28624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Opened libMesh/libmesh#3950 after whose conclusion we can revert this revert |
lindsayad
force-pushed
the
revert-28452-condensed-eigen-system-27262-refactor
branch
from
0e5ba32
to
e3efe51
Compare
|
fyi @YaqiWang |
|
Job Documentation on e3efe51 wanted to post the following: View the site here This comment will be updated on new commits. |
|
Job Coverage on e3efe51 wanted to post the following: Framework coverage
Modules coverageCoverage did not change Full coverage reportsReports
This comment will be updated on new commits. |
||||||||||||||||||||||||||
loganharbour
approved these changes
Sep 15, 2024
lindsayad
deleted the
revert-28452-condensed-eigen-system-27262-refactor
branch
|
Thanks for the fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #28452
This refactor didn't capture when the mesh changes