Restore location when case split #465
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
david-christiansen
requested changes
Dec 5, 2017
| @@ -576,8 +576,10 @@ KILLFLAG is set if N was explicitly specified." | |||
| (let ((result (car (idris-eval `(:case-split ,(cdr what) ,(car what)))))) | |||
| (if (<= (length result) 2) | |||
| (message "Can't case split %s" (car what)) | |||
| (setq final-point (point)) | |||
There was a problem hiding this comment.
This file is lexically scoped, so final-point isn't around right now. Why not let-bind it here, rather than using setq?
| @@ -588,8 +590,10 @@ KILLFLAG is set if N was explicitly specified." | |||
| (let ((result (car (idris-eval `(:make-case ,(cdr what) ,(car what)))))) | |||
| (if (<= (length result) 2) | |||
| (message "Can't make cases from %s" (car what)) | |||
| (setq final-point (point)) | |||
There was a problem hiding this comment.
This file is lexically scoped, so final-point isn't around right now. Why not let-bind it here, rather than using setq?
Also, did you test save-excursion rather than using goto-char like this?
|
Thanks! I'm a newbie to elisp. I will see if |
|
I'm happy to give feedback - sorry it took so long. |
keram
added a commit
to keram/idris-mode
that referenced
this pull request
Dec 7, 2022
Addresses feedback on idris-hackers#465 with small improvement for making case from hole where the point is moved back to position of `_` in `case _ of` as that is place user may most likely edit next. Closes idris-hackers#465
keram
added a commit
to keram/idris-mode
that referenced
this pull request
Dec 8, 2022
Addresses feedback on idris-hackers#465 with small improvement for making case from hole where the point is moved back to position of `_` in `case _ of` as that is place user may most likely edit next. Closes idris-hackers#465
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I always find it annoying every time I do case split on a variable or hole, the cursor would be put on the last of the clause, and I need to move backward several lines to do some editing.