Added crypto-key as an environment identifier #151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds $crypto-key-type-choice as a possible environment-map instance identifier
nedmsmith
requested review from
henkbirkholz,
thomas-fossati and
yogeshbdeshpande
as code owners
nedmsmith
requested review from
setrofim,
andrew-draper,
jdbeaney and
vinscarlata
vinscarlata
approved these changes
Sep 15, 2023
jdbeaney
approved these changes
Sep 15, 2023
thomas-fossati
approved these changes
Sep 27, 2023
| / comid.triples / 4 : { | ||
| / comid.reference-triples / 0 : [ [ | ||
| / environment-map / { | ||
| / comid.instance / 1 : / tagged-pkix-base64-key-type / 554("base64_key_X") |
There was a problem hiding this comment.
kudos for the self-explanatory base64-url encoded value :-)
andrew-draper
approved these changes
Sep 27, 2023
andrew-draper
approved these changes
Sep 27, 2023
There was a problem hiding this comment.
Issue #155 describes the need for enhancement of matching rules
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds $crypto-key-type-choice as a possible environment-map instance identifier.
Addresses Issue #146