Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify "standard CoRIM type" #206

Merged
merged 5 commits into from
Mar 6, 2024

Conversation

deeglaze
Copy link
Collaborator

There's a base schema and there's a standard type, so we ought to define the separate concepts.

There's a base schema and there's a standard type, so we ought to define
the separate concepts.

Signed-off-by: Dionna Glaze <dionnaglaze@google.com>
Copy link
Collaborator

@nedmsmith nedmsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added relevant standards.

@@ -453,6 +453,8 @@ that MUST have a different identifier.
{::include cddl/profile-type-choice.cddl}
~~~

A "standard CoRIM type" references definitions in {{sec-corim-cddl}} and any further definitions in relevant IANA registries.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
A "standard CoRIM type" references definitions in {{sec-corim-cddl}} and any further definitions in relevant IANA registries.
A "standard CoRIM type" references definitions in {{sec-corim-cddl}} and any further definitions in relevant standards or IANA registries.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this assumed to be IETF standard, or is there a list of expected standards bodies that extensions could come from?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There could be other I-D from IETF or even other standards organizations could extend. There are some control surfaces in terms of IANA registries for code points and CBOR tagging, but IANA doesn't constrain itself to IETF-only standards.

I'm not entirely clear on why this kind of wording in needed in the first place however. Is the "standard CoRIM type" terminology used elsewhere in the document?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's used in the document without definition, so unless you want to replace the current use to something clearer, we should add a definition. There's a "standard CoRIM extension" later referencing CoTS, but that seems like a different notion of extension than the map codepoint extensions.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would expect that any number in IANA registries would link to the standard document that introduced it and gives it meaning, which is why I just used the IANA registry. That's the one authority that can assign numbers that are used in these extension points, no?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think "standard CoRIM type" is referring to the codepoints within measurement-values-map but this isn't very clear from the text.

I wonder whether it would be better to say something along the lines of "a profile SHALL not redefine anything in this document, but it can add to it", which is what I think the current text is trying to say.

@yogeshbdeshpande
Copy link
Collaborator

@henk to raise another PR to add another section of linking profiles to extensibility.

Copy link
Collaborator

@yogeshbdeshpande yogeshbdeshpande left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yogeshbdeshpande yogeshbdeshpande merged commit 1f9b062 into ietf-rats-wg:main Mar 6, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants