Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ascii art #246

Merged
merged 2 commits into from
Jul 4, 2024
Merged

ascii art #246

merged 2 commits into from
Jul 4, 2024

Conversation

thomas-fossati
Copy link
Collaborator

some ascii art I have made that may be useful as-is or as a starting point

some ascii art I have made that may be useful as-is or as a starting point

Signed-off-by: Thomas Fossati <thomas.fossati@linaro.org>
@nedmsmith
Copy link
Collaborator

nedmsmith commented Jun 27, 2024

It is reasonable for the Verifier to assert new claims (which could be treated like endorsements) but the diagrams don't suggest this possibility exists. The use case for this is if the Verifier applies additional integrity checking operations (which is implied by the identity-key/attest-key triples and trust dependency triples. These are applied after the other endorsements, so it makes sense to show another ECS'''' IMHO. Possibly, our revised RATS Arch diagram should include a flow from the RP to the Verifier labeled "Interesting Claims". Trying to do this through some sort of backchannel between RP Owner and Verifier Owner seems dubious.

Also, the RATS Arch omitted a flow from the RP to the Verifier that allows the Verifier to know which claims are "interesting". This is different from Appraisal Policy because of the entity that originates it. Of course, we can say that this flow is out of scope (but exists), but it affects the staging. If the diagram models policy evaluation as a separate (but logical) phase, and the only input is appraisal policy then there isn't enough information available for an RP to specify a condition of which types of claims are interesting.

I also think there should be a box for Attestation Results Processing that formats internal formatted ARs into external formatted ARs and applies signatures. This is symmetrical with the CoRIM Processor box that verifies signatures on inputs and transforms external representations to internal representation.

Copy link
Collaborator

@nedmsmith nedmsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thomas-fossati thomas-fossati merged commit 8a150bb into main Jul 4, 2024
2 checks passed
@thomas-fossati thomas-fossati deleted the pics branch July 4, 2024 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants