Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove autogenerated files #25

Merged
merged 1 commit into from
Nov 23, 2022
Merged

remove autogenerated files #25

merged 1 commit into from
Nov 23, 2022

Conversation

thomas-fossati
Copy link
Collaborator

Signed-off-by: Thomas Fossati thomas.fossati@arm.com

Signed-off-by: Thomas Fossati <thomas.fossati@arm.com>
Copy link
Collaborator

@yogeshbdeshpande yogeshbdeshpande left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@yogeshbdeshpande yogeshbdeshpande merged commit 93aa69f into main Nov 23, 2022
@nedmsmith
Copy link
Collaborator

Should the examples be updated too? This change will break working examples.

@thomas-fossati
Copy link
Collaborator Author

Should the examples be updated too? This change will break working examples.

mmm in theory it shouldn't: the examples Makefile targets are predicated on the existence of the autogen files. Can you reproduce the problem?

@nedmsmith
Copy link
Collaborator

Can you reproduce the problem?

In the example cbor diag below from (https://github.com/ietf-rats-wg/draft-ietf-rats-corim/blob/main/cddl/examples/comid-1.diag), the array at / measurement-map / [ { and at the end } ] should be removed since the array was removed from the triple definition.

},
      / measurement-map / [ {
        / comid.mval / 1 : {
          / comid.ver / 0 : {
            / comid.version / 0 : "1.0.0",
            / comid.version-scheme / 1 : 16384 / semver /
          },
          / comid.digests / 2 : [ [
            / hash-alg-id / 1, / sha256 /
            / hash-value / h'44aa336af4cb14a879432e53dd6571c7fa9bccafb75f488259262d6ea3a4d91b'
          ] ]
        }
      } ]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants