Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow key thumbprints as authorized-by #53

Merged
merged 4 commits into from
Feb 28, 2023
Merged

allow key thumbprints as authorized-by #53

merged 4 commits into from
Feb 28, 2023

Conversation

thomas-fossati
Copy link
Collaborator

Fix #51

@thomas-fossati
allow key thumbprints as authorized-by
f08e843 
Fix #51

Signed-off-by: Thomas Fossati <thomas.fossati@arm.com>
@thomas-fossati
tweak the gitignore
61b6c7f 
Signed-off-by: Thomas Fossati <thomas.fossati@arm.com>
@nedmsmith
Copy link
Collaborator

Should this PR be updated to use COSE_CertHash = [ hashAlg: (int / tstr), hashValue: bstr ] ?

@thomas-fossati
Copy link
Collaborator Author

Should this PR be updated to use COSE_CertHash = [ hashAlg: (int / tstr), hashValue: bstr ] ?

I'll do the relaxation of the digests in a separate PR.

@thomas-fossati
Copy link
Collaborator Author

Should this PR be updated to use COSE_CertHash = [ hashAlg: (int / tstr), hashValue: bstr ] ?

I'll do the relaxation of the digests in a separate PR.

See #56

thomas-fossati
thomas-fossati commented Feb 24, 2023
View reviewed changes
cddl/cbor-tags.txt Outdated Show resolved Hide resolved
@thomas-fossati
Copy link
Collaborator Author

@nedmsmith I've updated based on #56

@thomas-fossati
Copy link
Collaborator Author

@nedmsmith @yogeshbdeshpande @henkbirkholz should I merge this?

@thomas-fossati thomas-fossati merged commit 5d27892 into main Feb 28, 2023
@thomas-fossati thomas-fossati deleted the authorized-by+thumbprint branch February 28, 2023 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nedmsmith nedmsmith nedmsmith approved these changes

@henkbirkholz henkbirkholz Awaiting requested review from henkbirkholz henkbirkholz is a code owner

@yogeshbdeshpande yogeshbdeshpande Awaiting requested review from yogeshbdeshpande yogeshbdeshpande is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

allow key thumbprints as authorized-by
2 participants
@thomas-fossati @nedmsmith