svn-type-choice #8 #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added prose to section describing svn and min-svn
nedmsmith
requested review from
henkbirkholz,
thomas-fossati and
yogeshbdeshpande
as code owners
fixed whitespace and wording issues
removed trailing white space
draft-ietf-rats-corim.md
Outdated
| @@ -825,6 +825,21 @@ $version-scheme /= int / text | |||
|
|
|||
| [^issue] https://github.com/ietf-rats-wg/draft-ietf-rats-corim/issues/8 | |||
|
|
|||
| The following describes details the security version number (svn) and the minimum security version number (min-svn). | |||
There was a problem hiding this comment.
There seems to be one or more missing piece(s) of English language here, but I can't tell exactly what :)
- The following describes in details the security [...]
- The following details the security [...]
- The following describes the details of the security [...]
There was a problem hiding this comment.
Ned, if you address this we can merge. (You may have missed this comment.)
Accept suggested change Co-authored-by: Thomas Fossati <tho.ietf@gmail.com>
accept suggested change Co-authored-by: Thomas Fossati <tho.ietf@gmail.com>
accept suggested change Co-authored-by: Thomas Fossati <tho.ietf@gmail.com>
accept suggested change. Co-authored-by: Thomas Fossati <tho.ietf@gmail.com>
reworded paragraph on svn-type-choice to avoid over use of 'object'
remove white space
added examplary text describing object instances.
improved examples of 'objects' Co-authored-by: Thomas Fossati <tho.ietf@gmail.com>
fixed capitalization
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added prose to section describing svn and min-svn
Fix #8