Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

silent information loss when formatting <postal> #437

Closed
ietf-svn-bot opened this issue Oct 2, 2019 · 9 comments
Closed

silent information loss when formatting <postal> #437

ietf-svn-bot opened this issue Oct 2, 2019 · 9 comments

Comments

@ietf-svn-bot
Copy link

resolution_fixed type_enhancement | by julian.reschke@gmx.de


In v3 mode, the formatter formats postal addresses according to the detected local of the address.

This leads to cases where information is silently dropped (such as for German addresses).

There are also cases where information is normalized (such as expanding "USA").

In both cases, the formatter should inform the user about these omissions/rewrites.


Issue migrated from trac:437 at 2022-02-05 12:50:50 +0000

@ietf-svn-bot
Copy link
Author

@henrik@levkowetz.com changed component from Version_3_cli_txt to v3 vocabulary, v2 xml2rfc

@ietf-svn-bot
Copy link
Author

@mahoney@nostrum.com commented


I'm also seeing issues with . The information tagged with isn't in the output (in this example, I modified the author name and address but kept the structure the same):

<author initials="J." surname="Doe" fullname="John Doe">

    <organization>Example, Inc.</organization>
    <address>

        <postal>

            <street>Parsec, Stonefort, Wesley</street>
            <city>Swindon</city>
            <region>Wilts</region>
            <country>UK</country>

        </postal>
        <email>​john@example.com</email>

    </address>

</author>

Renders:

John Doe
Example, Inc.
Parsec, Stonefort, Wesley
Swindon
United Kingdom
Email: ​john@example.com

@ietf-svn-bot
Copy link
Author

@mahoney@nostrum.com commented


After more digging, I ran xml2rfc with the --verbose option and was told:

draft-ietf-bfcpbis-rfc4582bis-16.xml(81): Warning: Postal address part filled in, but not used: : Wilts

@ietf-svn-bot
Copy link
Author

@henrik@levkowetz.com commented


Yes. There is a warning that isn't used for UK addresses, but it's silenced and only visible with --verbose, because of earlier complaints about Postal address warnings. I'm going to revert that silencing.

@ietf-svn-bot
Copy link
Author

@henrik@levkowetz.com commented


From 30a1dcd:

Reverted the silencing of warnings related to postal address input. Addresses issue #437.

@ietf-svn-bot
Copy link
Author

@henrik@levkowetz.com changed priority from medium to minor

@ietf-svn-bot
Copy link
Author

@henrik@levkowetz.com commented


Will wait with closing this until responses on the new behaviour is in. Lowering the priority after commit 30a1dcd.

@ietf-svn-bot
Copy link
Author

@henrik@levkowetz.com changed status from new to closed

@ietf-svn-bot
Copy link
Author

@henrik@levkowetz.com changed resolution from `` to fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant