Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

when rowspan is used in a table, the HTML output is lacking distinct rows #494

Closed
ietf-svn-bot opened this issue Feb 18, 2020 · 5 comments
Closed

Comments

@ietf-svn-bot
Copy link

resolution_fixed type_defect | by arusso@amsl.com


When rowspan is used, the rows do not alternate background color (gray/white), so the rows are not as distinct.

Example:
https://www.rfc-editor.org/authors/rfc8736.html#table-1

  • rows for types 4 and 5 (both gray)
  • rows for types 10 and 11 (both white)
  • last two rows (both gray)

The same issue is in the PDF output, but it's less problematic for readability because there are horizontal lines used to separate rows:
https://www.rfc-editor.org/authors/rfc8736.pdf
(However, Table 1 contains a bad page break within the row for type 12.)

https://www.rfc-editor.org/authors/rfc8736.xml


Issue migrated from trac:494 at 2022-02-08 07:06:18 +0000

@ietf-svn-bot
Copy link
Author

@henrik@levkowetz.com commented


The table row colourisation is purely an CSS style issue. Giving the HTML row borders is trivial. Are the row borders currently present in PDF sufficiently distinct, or is a darker colour indicated?

(The bad page break is a different issue, and I'll have to see if it's possible to do something about it separately).

@ietf-svn-bot
Copy link
Author

@arusso@amsl.com commented


The borders in the PDF are sufficiently distinct. (Also fine with making them a darker color.) Thanks.

@ietf-svn-bot
Copy link
Author

@henrik@levkowetz.com changed status from new to closed

@ietf-svn-bot
Copy link
Author

@henrik@levkowetz.com changed resolution from `` to fixed

@ietf-svn-bot
Copy link
Author

@henrik@levkowetz.com commented


Fixed in fe06b7d:

Made table and row borders the same for print and HTML on request from the RPC, and increased the contrast between borders and odd row background colour slightly. Fixes issue #494.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant