Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xml2rfc 2.3.11 and format %i. #94

Closed
ietf-svn-bot opened this issue Jan 18, 2013 · 12 comments
Closed

xml2rfc 2.3.11 and format %i. #94

ietf-svn-bot opened this issue Jan 18, 2013 · 12 comments
Labels

Comments

@ietf-svn-bot
Copy link

resolution_fixed type_defect | by miek@miek.nl


Thanks for you work, I'm using the svn version atm to see what has changed, between 2.3.10 and 2.3.11.

I noticed the following:

-> 2.3.10 (text output):

    i. Item one;
    
    ii. Item two.

In 2.3.11:
-> 2.3.11 (text output):

    i    . Item one;
    ii   . Item two.

Issue migrated from trac:94 at 2022-02-05 12:27:50 +0000

@ietf-svn-bot
Copy link
Author

@miek@miek.nl commented


Hmm, this didn't come over right.

I don't like the 5 spaces afer typesetting the roman numeral. It should be possible to use something like 'format %2i' or the like? So one can specify the amount of spacing. Even then, it looks like a bit too much. IOW I like the v1 behavior better.

@ietf-svn-bot
Copy link
Author

@henrik@levkowetz.com commented


I knew this might be a controversial change, and I did consider adding in a field width
specifier, but wanted to test the waters first. (See the release notes, which mentions
the field width tweak for roman numerals. :-)

You mention only the i., ii. case, but I wonder if you in real life usage, when looking
at a more substantial list like

i. Lorem ipsum dolor sit amet, consectetur adipiscing elit. Vestibulum

ii. Proin cursus scelerisque luctus. Ut viverra dui eget ipsum eleifend

iii. Pellentesque rhoncus pellentesque felis at laoreet. Sed fringilla

iv. Nunc molestie consequat lobortis. Sed dictum aliquam ipsum, ut

v. Sed quam ipsum, facilisis sit amet tempor at, egestas eget lorem.

vi. Donec egestas, nisi sed adipiscing facilisis, est metus elementum

vii. Nulla et felis at nisi tincidunt bibendum. In vestibulum risus sit

viii. Quisque vestibulum feugiat vehicula. Vestibulum ut laoreet elit.

ix. Proin a urna lorem, eget volutpat enim. Donec fermentum tristique

x. Aliquam erat volutpat. Suspendisse aliquam nunc vitae sem adipiscing

compared with

i.    Lorem ipsum dolor sit amet, consectetur adipiscing elit. Vestibulum

ii.   Proin cursus scelerisque luctus. Ut viverra dui eget ipsum eleifend

iii.  Pellentesque rhoncus pellentesque felis at laoreet. Sed fringilla

iv.   Nunc molestie consequat lobortis. Sed dictum aliquam ipsum, ut

v.    Sed quam ipsum, facilisis sit amet tempor at, egestas eget lorem.

vi.   Donec egestas, nisi sed adipiscing facilisis, est metus elementum

vii.  Nulla et felis at nisi tincidunt bibendum. In vestibulum risus sit

viii. Quisque vestibulum feugiat vehicula. Vestibulum ut laoreet elit.

ix.   Proin a urna lorem, eget volutpat enim. Donec fermentum tristique

x.    Aliquam erat volutpat. Suspendisse aliquam nunc vitae sem adipiscing

will still prefer the version with variable text start position...

@ietf-svn-bot
Copy link
Author

@henrik@levkowetz.com changed priority from medium to minor

@ietf-svn-bot
Copy link
Author

@henrik@levkowetz.com changed component from Version 2 build to Version 2 cli

@ietf-svn-bot
Copy link
Author

@miek@miek.nl commented


Yeah, but now it looks:

i     . Lorem ipsum
ii    . Prion....
iii   . Pellen...

@ietf-svn-bot
Copy link
Author

@henrik@levkowetz.com commented


Ahh... :-)

That's an Oops, indeed.

@ietf-svn-bot
Copy link
Author

@henrik@levkowetz.com edited the issue description

@ietf-svn-bot
Copy link
Author

@henrik@levkowetz.com commented


Edited description to make the original point obvious (it was lost due to html swallowing whitespace, at first)

@ietf-svn-bot
Copy link
Author

@henrik@levkowetz.com commented


From 6d11289:

Updated tests to show flaw in rendering of lists using roman numerals with surrounding characters, see issue #94.

@ietf-svn-bot
Copy link
Author

@henrik@levkowetz.com changed status from new to closed

@ietf-svn-bot
Copy link
Author

@henrik@levkowetz.com changed resolution from `` to fixed

@ietf-svn-bot
Copy link
Author

@henrik@levkowetz.com commented


Fixed in 2cdbb66:

Reworked code to render roman numerals in lists, to place whitespace correctly in justification field. Fixes issue #94.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant