Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: List required dependencies #1057

Merged
merged 1 commit into from
Dec 13, 2023
Merged

Conversation

kesara
Copy link
Member

@kesara kesara commented Nov 20, 2023

file: requirements.txt is only supported by setuptools>=62.6.

Fixes #1049

@kesara kesara requested a review from rjsparks November 20, 2023 16:02
@kesara kesara force-pushed the fix/setup-issue branch 2 times, most recently from cbe5711 to 0cfeb49 Compare November 21, 2023 08:21
@kesara kesara marked this pull request as draft November 21, 2023 08:29
@kesara
Copy link
Member Author

kesara commented Nov 21, 2023

The current set of changes uses pyproject.toml more. But this lets us keep requirements in a single place.
The only downside is when installing on the system (without using venv) xml2rfc doesn't install the dependencies under Ubuntu 22.04 LTS.
It works fine when installed within a venv.

Using pip bare is warning users as well:

WARNING: Running pip as the 'root' user can result in broken permissions and conflicting behaviour with the system package manager. It is recommended to use a virtual environment instead: https://pip.pypa.io/warnings/venv

file: requirements.txt is only supported by setuptools>=62.6.
Fixes ietf-tools#1049
@kesara
Copy link
Member Author

kesara commented Dec 12, 2023

It seems like we have to define requirements in setup.cfg as a list to make this particular version setup happy.

@kesara kesara marked this pull request as ready for review December 12, 2023 17:55
@kesara kesara merged commit 880d20d into ietf-tools:main Dec 13, 2023
13 checks passed
@kesara kesara deleted the fix/setup-issue branch December 13, 2023 20:00
@kesara kesara mentioned this pull request Mar 27, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Installation fails with pip3
2 participants