Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Add Noto Sans Symbols 2 font to PDF template #926

Merged
merged 3 commits into from
Oct 28, 2022
Merged

fix: Add Noto Sans Symbols 2 font to PDF template #926

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b6c43b4
fix: Add Noto Sans Symbols 2 font to PDF template
kesara Oct 28, 2022
9e88f46
fixup! fix: Add Noto Sans Symbols 2 font to PDF template
kesara Oct 28, 2022
91f1ea3
fixup! fix: Add Noto Sans Symbols 2 font to PDF template
kesara Oct 28, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion xml2rfc/writers/pdf.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,11 +124,12 @@ def get_serif_fonts(self):
fonts = set()
scripts = self.root.get('scripts').split(',')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since you're here, may as well convert the whole method to scratch the itch you felt in the first place.
But don't hold up a release over it.

noto_serif = "Noto Serif"
noto_symbols = "NotoSansSymbols2"
for script in scripts:
family = get_noto_serif_family_for_script(script)
fonts.add("%s" % family)
fonts -= set([ noto_serif, ])
fonts = [ noto_serif, ] + list(fonts)
fonts = [noto_serif, noto_symbols] + list(fonts)
self.note(None, "Found installed font: %s" % ', '.join(fonts))
return fonts

Expand Down