Introduce OT namespce to avoid clash with other libraries #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes the following clash with STM32 platform from: https://github.com/stm32duino/Arduino_Core_STM32 opentherm_library/src/OpenTherm.h:21:2: error: 'SUCCESS' conflicts with a previous declaration SUCCESS, ^~~~~~~ In file included from /home/sw/.arduino15/packages/STM32/hardware/stm32/1.6.0-dev/cores/arduino/stm32/stm32_def.h:29, from /home/sw/.arduino15/packages/STM32/hardware/stm32/1.6.0-dev/cores/arduino/stm32/clock.h:43, from /home/sw/.arduino15/packages/STM32/hardware/stm32/1.6.0-dev/cores/arduino/wiring_time.h:23, from /home/sw/.arduino15/packages/STM32/hardware/stm32/1.6.0-dev/cores/arduino/wiring.h:38, from /home/sw/.arduino15/packages/STM32/hardware/stm32/1.6.0-dev/cores/arduino/Arduino.h:32, from /home/sw/Arduino/OT-Adapter/.build/sketch/OT-Adapter.ino.cpp:1: /home/sw/.arduino15/packages/STM32/hardware/stm32/1.6.0-dev/system/Drivers/CMSIS/Device/ST/STM32F1xx/Include/stm32f1xx.h:185:3: note: previous declaration 'ErrorStatus SUCCESS' SUCCESS = !ERROR ^~~~~~~
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the following clash with STM32 platform from:
https://github.com/stm32duino/Arduino_Core_STM32
opentherm_library/src/OpenTherm.h:21:2: error: 'SUCCESS' conflicts with a previous declaration
SUCCESS,
^~~~~~~
In file included from /home/sw/.arduino15/packages/STM32/hardware/stm32/1.6.0-dev/cores/arduino/stm32/stm32_def.h:29,
from /home/sw/.arduino15/packages/STM32/hardware/stm32/1.6.0-dev/cores/arduino/stm32/clock.h:43,
from /home/sw/.arduino15/packages/STM32/hardware/stm32/1.6.0-dev/cores/arduino/wiring_time.h:23,
from /home/sw/.arduino15/packages/STM32/hardware/stm32/1.6.0-dev/cores/arduino/wiring.h:38,
from /home/sw/.arduino15/packages/STM32/hardware/stm32/1.6.0-dev/cores/arduino/Arduino.h:32,
from /home/sw/Arduino/OT-Adapter/.build/sketch/OT-Adapter.ino.cpp:1:
/home/sw/.arduino15/packages/STM32/hardware/stm32/1.6.0-dev/system/Drivers/CMSIS/Device/ST/STM32F1xx/Include/stm32f1xx.h:185:3: note: previous declaration 'ErrorStatus SUCCESS'
SUCCESS = !ERROR
^~~~~~~