fix: crash when not declaring anim/sprite files on char, move "no-sprite" anim from -2 to -1 #1448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
PR: fix
Lazin3ss
changed the title
github-actions
bot
added
PR: fix
Lazin3ss
added a commit
to Lazin3ss/Ikemen-GO
that referenced
this pull request
Oct 24, 2023
Clamp-to-zero animation now only applies to ChangeAnim/ChangeAnim2 SCTRLs, since that's how it really works in MUGEN. Changing anims from ChangeState SCTRLs or Statedef doesn't do this.
Lazin3ss
added a commit
to Lazin3ss/Ikemen-GO
that referenced
this pull request
Oct 26, 2023
Anim No. negative values are now being handled like this: - In ChangeAnim/ChangeAnim2 SCTRL: Any negative value (except for -2) is clamped to 0 - In ChangeState/SelfState SCTRL: Any negative value (except for -1 and -2) is clamped to 0 - In StateDef: Any negative value (except for -1 and -2) throws a warning message in the console This is the best approach to mixing MUGEN 1.1 handling of negative values and Ikemen GO's -2 anim (which is a 'no-sprite' anim).
K4thos
added a commit
that referenced
this pull request
Oct 26, 2023
fix: Refine anim no. handling from #1448, PlayBGM SCTRL leaking to the character select screen
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, negative anim handling was improved to fix some dizzy system issues.
BREAKING CHANGE:
"No-sprite" anim used to be "-2", but now it's "-1".