Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more liter-based volume rates. #121

Merged
merged 1 commit into from
Apr 2, 2019
Merged

Add more liter-based volume rates. #121

merged 1 commit into from
Apr 2, 2019

Conversation

Aehmlo
Copy link
Contributor

@Aehmlo Aehmlo commented Apr 1, 2019

I totally forgot to do this in #116, but it was the main motivation for doing that (d'oh!).

iliekturtles
iliekturtles requested changes Apr 2, 2019
View reviewed changes
Copy link
Owner

@iliekturtles iliekturtles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one minor formatting change. Did you want me to release v0.22.1 so these are available on crates.io or is waiting for a larger release OK?

src/si/volume_rate.rs Outdated Show resolved Hide resolved
@Aehmlo
Copy link
Contributor Author

Aehmlo commented Apr 2, 2019

If you're willing, a patch release would be great.

@coveralls
Copy link

coveralls commented Apr 2, 2019 •
edited
Loading

Coverage Status

Coverage increased (+0.04%) to 97.113% when pulling 65c41b7 on Aehmlo:volume-rate into cd0baa1 on iliekturtles:master.

@iliekturtles iliekturtles merged commit 65749fe into iliekturtles:master Apr 2, 2019
@iliekturtles
Copy link
Owner

Thanks! I'll try to get the changes released later today or tonight.

@Aehmlo Aehmlo deleted the volume-rate branch April 2, 2019 17:33
@iliekturtles
Copy link
Owner

v0.22.1 released!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iliekturtles iliekturtles iliekturtles approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Aehmlo @coveralls @iliekturtles