Skip to content

Commit

Permalink
address comment
Browse files Browse the repository at this point in the history
  • Loading branch information
imback82 committed Nov 8, 2023
1 parent 328e461 commit 9e52100
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -49,8 +49,6 @@ trait CreateTableClusterBySuiteBase extends QueryTest with DDLCommandTestUtils {
}

test("test clustering columns with comma") {
assume(!catalogVersion.contains("Hive")) // Hive catalog doesn't support column names with dots.

withNamespaceAndTable("ns", "table") { tbl =>
spark.sql(s"CREATE TABLE $tbl (`i,d` INT, data STRING) $defaultUsing " +
"CLUSTER BY (`i,d`, data)")
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -30,5 +30,10 @@ class CreateTableClusterBySuite extends v1.CreateTableClusterBySuiteBase with Co
override protected val nestedClusteringColumns: Seq[String] =
Seq("col2.col3")

// Hive catalog doesn't support column names with commas.
override def excluded: Seq[String] = Seq(
s"$command using Hive V1 catalog V1 command: test clustering columns with comma",
s"$command using Hive V1 catalog V2 command: test clustering columns with comma")

override def commandVersion: String = super[CreateTableClusterBySuiteBase].commandVersion
}

0 comments on commit 9e52100

Please sign in to comment.