Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: RTL chevron rotation #302

Merged
merged 3 commits into from
Feb 20, 2024
Merged

fix: RTL chevron rotation #302

merged 3 commits into from
Feb 20, 2024

Conversation

Goudarz
Copy link
Contributor

@Goudarz Goudarz commented Feb 19, 2024

No description provided.

Copy link

netlify bot commented Feb 19, 2024

Deploy Preview for hugo-hextra ready!

Name Link
🔨 Latest commit 854609b
🔍 Latest deploy log https://app.netlify.com/sites/hugo-hextra/deploys/65d4accff65db600088435d3
😎 Deploy Preview https://deploy-preview-302--hugo-hextra.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Goudarz Goudarz changed the title fix: RTL chevron issue fix: RTL chevron Feb 19, 2024
Copy link
Owner

@imfing imfing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in this case, we could just use Tailwind CSS to rotate the chevron icon:

Handling Hover, Focus, and Other States - Tailwind CSS

you may need to run npm run build:css to compile the CSS styles and commit it after the above changes have been made.

layouts/partials/breadcrumb.html Outdated Show resolved Hide resolved
layouts/partials/components/pager.html Outdated Show resolved Hide resolved
@Goudarz
Copy link
Contributor Author

Goudarz commented Feb 20, 2024

@imfing, The files has been updated according to the documentation. 👍

@Goudarz Goudarz requested a review from imfing February 20, 2024 13:50
Copy link
Owner

@imfing imfing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Goudarz awesome, thank you!

@imfing imfing changed the title fix: RTL chevron fix: RTL chevron rotation Feb 20, 2024
@imfing imfing merged commit b1f49c0 into imfing:main Feb 20, 2024
4 checks passed
@Goudarz Goudarz deleted the fix-rtl branch February 24, 2024 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants