-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: shortcode for Jupyter Notebook #337
Conversation
✅ Deploy Preview for hugo-hextra ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Very cool, thank you. |
Hi @imfing This is great! I just tested this branch for a use case and it worked perfectly. If I had any complaint, it'd be that I'd prefer host the notebooks in the same directory, like Just wondering, is there any reason you don't want to merge this to main? I would start using it right away. |
Ah, one other: it seems the headings don't show in the ToC, having tried with both |
@MattDodsonEnglish Thank you for the feedback.
I think I will probably merge this as is once I resolve the conflicts.
I didn't figure out a way to make Jupyter work nicely in Hugo so that we can essentially use jupyter notebooks instead of
This can be supported as what we can do for images: https://imfing.github.io/hextra/docs/guide/organize-files/#add-images
I'll try to address this, but I'm not sure if this is a easy thing. |
From what I tried, I don't know how easy this is to do it elegantly. Using something like this with
|
One more request: would it be possible to keep the copy button in the cells? It's a nice UX boost for readers who just want to grab a little sample from the wider notebook flow. |
- use raw markdown for contents like code block and markdown text
- update docs accordingly - add example notebook file
@MattDodsonEnglish yes, see the latest demo page: https://deploy-preview-337--hugo-hextra.netlify.app/docs/guide/shortcodes/jupyter/ |
@imfing preliminary test looks great, with ToC too. Thanks 🙇 |
@MattDodsonEnglish let me know if things don't work as expected 🙌 |
Experimental shortcode to include jupyter notebook in a page. In the future, it will enable using a notebook file as an individual page.
Example usage: