Fix Random thread safety.(#502) (#579)

imperugo · Dec 25, 2023 · eb461df · eb461df
1 parent 8ad186b
commit eb461df
Showing 1 changed file with 6 additions and 2 deletions.
diff --git a/src/core/StackExchange.Redis.Extensions.Core/Implementations/RedisConnectionPoolManager.cs b/src/core/StackExchange.Redis.Extensions.Core/Implementations/RedisConnectionPoolManager.cs
@@ -21,7 +21,6 @@ public sealed partial class RedisConnectionPoolManager : IRedisConnectionPoolMan
     private readonly IStateAwareConnection[] connections;
     private readonly RedisConfiguration redisConfiguration;
     private readonly ILogger<RedisConnectionPoolManager> logger;
-    private readonly Random random = new();
     private bool isDisposed;
 
     /// <summary>
@@ -71,7 +70,12 @@ public IConnectionMultiplexer GetConnection()
         switch (redisConfiguration.ConnectionSelectionStrategy)
         {
             case ConnectionSelectionStrategy.RoundRobin:
-                var nextIdx = random.Next(0, redisConfiguration.PoolSize);
+                var nextIdx
+#if NET6_0_OR_GREATER
+                = Random.Shared.Next(0, redisConfiguration.PoolSize);
+#else
+                = new Random().Next(0, redisConfiguration.PoolSize);
+#endif
                 connection = connections[nextIdx];
                 break;