[utils] [refactor] parse: avoid using a regex here

import-js · Oct 3, 2024 · 3f1ac24 · 3f1ac24
1 parent d225176
commit 3f1ac24
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/utils/CHANGELOG.md b/utils/CHANGELOG.md
@@ -5,6 +5,9 @@ This change log adheres to standards from [Keep a CHANGELOG](https://keepachange
 
 ## Unreleased
 
+### Changed
+- [refactor] `parse`: avoid using a regex here (thanks [@ljharb])
+
 ## v2.12.0 - 2024-09-26
 
 ### Added

diff --git a/utils/parse.js b/utils/parse.js
@@ -33,7 +33,7 @@ function keysFromParser(parserPath, parserInstance, parsedResult) {
   // up with a `parsedResult` here.  It also doesn't expose the visitor keys on the parser itself,
   // so we have to try and infer the visitor-keys module from the parserPath.
   // This is NOT supported in flat config!
-  if (typeof parserPath === 'string' && (/.*babel-eslint.*/).test(parserPath)) {
+  if (typeof parserPath === 'string' && parserPath.indexOf('babel-eslint') > -1) {
     return getBabelEslintVisitorKeys(parserPath);
   }
   // The espree parser doesn't have the `parseForESLint` function, so we don't end up with a