Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] named: ignore Flow import typeof and export type #1345

Merged
merged 1 commit into from
Apr 25, 2019

Conversation

loganfsmyth
Copy link
Contributor

Expand the cases added by #1057 and #1106 to handle the other forms of Flow import/export.

@loganfsmyth loganfsmyth force-pushed the handle-more-flow branch 2 times, most recently from 9c077fe to 04059c0 Compare April 25, 2019 02:31
@coveralls
Copy link

Coverage Status

Coverage increased (+2.5%) to 97.933% when pulling 04059c0 on loganfsmyth:handle-more-flow into c17dd73 on benmosher:master.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage increased (+2.5%) to 97.933% when pulling 04059c0 on loganfsmyth:handle-more-flow into c17dd73 on benmosher:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+2.5%) to 97.933% when pulling 04059c0 on loganfsmyth:handle-more-flow into c17dd73 on benmosher:master.

@coveralls
Copy link

coveralls commented Apr 25, 2019

Coverage Status

Coverage increased (+2.5%) to 97.933% when pulling 4620185 on loganfsmyth:handle-more-flow into c17dd73 on benmosher:master.

@ljharb ljharb added the flow label Apr 25, 2019
@@ -5,6 +5,8 @@ This change log adheres to standards from [Keep a CHANGELOG](http://keepachangel

## [Unreleased]

- [`named`]: ignore Flow `typeof` imports and `type` exports ([#1345], thanks [@loganfsmyth])
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you’ll need an explicit link for the pr number (see the bottom) and one for your name if you haven’t contributed previously

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woops, fixed! Copy-pasted and just assumed it was some feature of Github linking I didn't know about hahah.

@ljharb ljharb merged commit 4620185 into import-js:master Apr 25, 2019
@loganfsmyth loganfsmyth deleted the handle-more-flow branch April 25, 2019 19:34
@loganfsmyth
Copy link
Contributor Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

3 participants