Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tests] no-extraneous-dependencies: add tests for importing types #1824

Merged
merged 1 commit into from
Jun 14, 2020

Conversation

taye
Copy link
Contributor

@taye taye commented Jun 13, 2020

Thanks for your work on this plugin! ❤️

This PR extends no-extranaeous-dependencies' check for Flow type imports to also work with TypeScript. This should help with #903 (comment).

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.3%) to 97.502% when pulling df1f80f on taye:fix-allow-extranaeous-type-import into 54eb51b on benmosher:master.

3 similar comments
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.3%) to 97.502% when pulling df1f80f on taye:fix-allow-extranaeous-type-import into 54eb51b on benmosher:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.3%) to 97.502% when pulling df1f80f on taye:fix-allow-extranaeous-type-import into 54eb51b on benmosher:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.3%) to 97.502% when pulling df1f80f on taye:fix-allow-extranaeous-type-import into 54eb51b on benmosher:master.

@coveralls
Copy link

coveralls commented Jun 13, 2020

Coverage Status

Coverage remained the same at 97.847% when pulling 6f5d95a on taye:fix-allow-extranaeous-type-import into f7c7d79 on benmosher:master.

@taye taye force-pushed the fix-allow-extranaeous-type-import branch from df1f80f to 23e9dc9 Compare June 13, 2020 12:15
@ljharb
Copy link
Member

ljharb commented Jun 13, 2020

This seems to be a duplicate of #1820.

I'll land that, and rebase this to include the test case. Thanks!

@ljharb ljharb force-pushed the fix-allow-extranaeous-type-import branch from 23e9dc9 to 6ed7446 Compare June 14, 2020 04:34
@ljharb ljharb changed the title fix(no-extranaeous-dependencies): check if node.parent.importKind is 'type' [Tests] no-extraneous-dependencies: add tests for importing types Jun 14, 2020
@ljharb ljharb force-pushed the fix-allow-extranaeous-type-import branch from 6ed7446 to 6f5d95a Compare June 14, 2020 06:12
@ljharb ljharb merged commit 6f5d95a into import-js:master Jun 14, 2020
@taye
Copy link
Contributor Author

taye commented Jun 14, 2020

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants