Better Logstash syntax #8
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Logstash syntax definition: https://github.com/elastic/logstash/blob/master/logstash-core/lib/logsta sh/config/grammar.treetop Ruby Regex definition: http://ruby-doc.org/core-2.2.0/Regexp.html
|
This change appears to break all the specs? |
|
It's because my syntax highlighter produces other tokens than yours. I wrote my syntax highlighter from scratch and tokens are inspired by ruby syntax highlighter. Unfortunately, I do not know exactly how the specs works and how to fix them. |
|
I can't really accept a PR that breaks the existing specs as people are actively using this. The specs are pretty straight forward, if you want to push ahead with the new highlighter perhaps you can have a go at fixing them? |
|
OK, I try to learn what the specs are and how to fix them. |
|
I'll get some bandwidth in the next week or so and try and sort it. Can you paste me some screen shots and sample configs and I'll be able to replicate what you want. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Richard,
today I have wanted to release my own language-logstash syntax highlighter for Atom and I found your work. I think we don't need two projects about it so I'm sending my grammar as pull request.
It's based on Logstash syntax definition and Ruby Regex definition.
If you would like my grammar, I'll be glad when you incorporate it into your project.
P.