Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: explicitly set serviceAccountName in deployment podspec #371

Merged
merged 2 commits into from
Sep 6, 2024

Conversation

ericwyles
Copy link
Contributor

What this PR does / why we need it

This uses the existing archivista.serviceAccountName from helpers to explicitly set the serviceAccountName for pods. Without this change the pods still use the default service account even if a different service account is created by the helm chart when serviceAccount.create is true.

Which issue(s) this PR fixes (optional)

Fixes #370

Acceptance Criteria Met

  • Docs changes if needed
  • Testing changes if needed
  • All workflow checks passing (automatically enforced)
  • All review conversations resolved (automatically enforced)
  • DCO Sign-off

Special notes for your reviewer:

Signed-off-by: Eric Wyles <23637493+ericwyles@users.noreply.github.com>
@ericwyles ericwyles changed the title fix: explicitly set serviceaccount name in deployment podspec fix: explicitly set serviceAccountName in deployment podspec Sep 5, 2024
Copy link

codecov bot commented Sep 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 1.64%. Comparing base (a035c62) to head (0867c9a).
Report is 160 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #371       +/-   ##
==========================================
- Coverage   82.40%   1.64%   -80.76%     
==========================================
  Files          10     120      +110     
  Lines         358   28845    +28487     
==========================================
+ Hits          295     474      +179     
- Misses         43   28314    +28271     
- Partials       20      57       +37     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@mikhailswift mikhailswift left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this fix!

@mikhailswift mikhailswift merged commit 45c1012 into in-toto:main Sep 6, 2024
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Pods still use default service account even if serviceAccount.create is true in the helm chart
3 participants