Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

basePath should be considered part of the trails path #25

Closed
elbrujohalcon opened this issue Oct 14, 2015 · 1 comment
Closed

basePath should be considered part of the trails path #25

elbrujohalcon opened this issue Oct 14, 2015 · 1 comment
Assignees

Comments

@elbrujohalcon
Copy link
Member

Even when #22 is fixed by just setting basePath => "", sometimes having a basePath (e.g. /admin/api) is actually useful, but swagger has to consider that such a basePath will be included in the trails routes, at least until inaka/cowboy-trails#22 is implemented. And in that case, basePath should be taken from there and not as an extra swagger property.

@Euen
Copy link
Member

Euen commented Dec 1, 2015

screen shot 2015-12-01 at 12 09 53 pm

Var baseUrl needs to be updated to change this text field adding the corresponding api_root

e.g. change

http://localhost:8383/api-docs/swagger.json

to

http://localhost:8383/admin/api/api-docs/swagger.json

harenson added a commit that referenced this issue Dec 2, 2015
harenson added a commit that referenced this issue Dec 2, 2015
elbrujohalcon pushed a commit that referenced this issue Dec 2, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants