Allow for analysis under rebar3_hank

.github/workflows/ci.yml

@@ -23,5 +23,6 @@ jobs:
           rebar3-version: '3.14'
       - run: rebar3 xref
       - run: rebar3 lint
+      - run: rebar3 hank
       - run: rebar3 dialyzer
       - run: rebar3 ct

elvis.config

@@ -5,12 +5,8 @@
     {config,
      [#{dirs => ["src", "test"],
         filter => "*.erl",
-        ruleset => erl_files
-       },
-      #{dirs => ["."],
-        filter => "Makefile",
-        rules => [{elvis_project, protocol_for_deps_erlang_mk, #{regex => "(https://.*|[0-9]+([.][0-9]+)*)"}}],
-        ruleset => makefiles
+        ruleset => erl_files,
+        rules => [{elvis_style, atom_naming_convention, #{ regex => "^(([a-z][a-z0-9]*_?)*(_SUITE)?|basePath|swagger_2_0|openapi_3_0_0)$" }}]
        },
       #{dirs => ["."],
         filter => "rebar.config",

rebar.config

@@ -96,4 +96,18 @@
 
 %% == Shell ==
 
-{plugins, [rebar3_auto, {rebar3_lint, "0.2.0"}, rebar3_hex]}.
+{project_plugins, [
+    rebar3_auto,
+    rebar3_lint,
+    rebar3_hex,
+    rebar3_hank
+]}.
+
+%% == hank ==
+
+{hank, [
+    {ignore, [
+        {"example/**", unnecessary_function_arguments},
+        {"test/**", unnecessary_function_arguments}
+    ]}
+]}.

src/cowboy_swagger.erl

@@ -11,6 +11,9 @@
 -export([filter_cowboy_swagger_handler/1]).
 -export([get_existing_definitions/1]).
 
+% is_visible is used as a maps:filter/2 predicate, which requires a /2 arity function
+-hank([{unnecessary_function_arguments, [is_visible/2]}]).
+
 %%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%
 %% Types.
 %%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%