Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed dialyser error 'no local return' then definition includes an array #80

Merged
merged 2 commits into from
Oct 12, 2016
Merged

fixed dialyser error 'no local return' then definition includes an array #80

merged 2 commits into from
Oct 12, 2016

Conversation

freke
Copy link
Contributor

@freke freke commented Oct 12, 2016 •
edited
Loading

For the following example dialyzer will currently return the error "no local return" but generate a correct swagger.json file

Properties =
  #{<<"name">> =>
      #{ type => <<"string">>
      ,  description => <<"description">>
      }
  , <<"list">> =>
    #{type => <<"array">>
    , items => #{ type => <<"integer">> }
    }
  },
  ok = cowboy_swagger:add_definition(<<"PropertieName">>, Properties).

this pull request fixes the spec so dialyzer is happy

elbrujohalcon
elbrujohalcon requested changes Oct 12, 2016
View reviewed changes
src/cowboy_swagger.erl
}}.
-type property_desc() ::
#{ type => binary()
, description => binary()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add one extra space in these lines so that , is aligned with { and }?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it correct now?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, sir.

@elbrujohalcon elbrujohalcon merged commit 68ce9de into inaka:master Oct 12, 2016
@freke freke mentioned this pull request Oct 12, 2016
Merged
freke added a commit to freke/cowboy-swagger that referenced this pull request Oct 12, 2016
@freke
fixed dialyser error 'no local return' then definition includes an ar…
ca052e0 
…ray (inaka#80) (#1)

* fixed dialyser error 'no local return' then definition includes an array

* fixed indentation
@freke freke deleted the dialyzer-error-no-local-return branch October 12, 2016 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elbrujohalcon elbrujohalcon elbrujohalcon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@freke @elbrujohalcon