[#120] Show stacktrace. Return no items for error results.

inaka · Sep 15, 2014 · b835986 · b835986
1 parent 0a043cb
commit b835986
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/src/elvis.erl b/src/elvis.erl
@@ -141,8 +141,10 @@ apply_rule({Module, Function, Args}, {Result, Config, File}) ->
                      elvis_result:new(rule, Function, Results)
                  catch
                      _:Reason ->
-                         Msg = "'~p' while applying rule '~p'.",
-                         elvis_result:new(error, Msg, [Reason, Function])
+                         Msg = "'~p' while applying rule '~p' - ~p",
+                         StackTrace = erlang:get_stacktrace(),
+                         Info = [Reason, Function, StackTrace],
+                         elvis_result:new(error, Msg, Info)
                  end,
     {[RuleResult | Result], Config, File}.
 

diff --git a/src/elvis_result.erl b/src/elvis_result.erl
@@ -79,7 +79,8 @@ get_rules(#{rules := Rules}) -> Rules.
 get_name(#{name := Name}) -> Name.
 
 -spec get_items(rule()) -> [item()].
-get_items(#{items := Items}) -> Items.
+get_items(#{items := Items}) -> Items;
+get_items(_) -> [].
 
 -spec get_message(item()) -> string().
 get_message(#{message := Message}) -> Message.