Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problems with printing UTF in comments. #179

Closed
mpmiszczyk opened this issue Nov 24, 2014 · 1 comment
Closed

Problems with printing UTF in comments. #179

mpmiszczyk opened this issue Nov 24, 2014 · 1 comment
Labels
Milestone

Comments

@mpmiszczyk
Copy link

If line have some non-acii chars, comment on github could be little hard to read:

Line 25 is too long: [32,32,103,98,95,116,114,101,101,115,58,102,114,111,109,
95,111,114,100,100,105,99,116,40,91,123,80,111,115,44,
32,35,97,110,116,123,112,111,115,32,61,32,80,111,115,44,
32,115,116,97,116,101,32,61,32,109,111,100,101,108,58,
114,97,110,100,111,109,95,97,110,116,95,115,116,97,116,
101,40,67,111,110,102,105,103,41,125,125,32,124,124,32,
80,111,115,32,60,45,32,108,105,115,116,115,58,115,111,
114,116,40,65,110,116,80,111,115,105,116,105,111,110,
115,41,93,41,46,32,37,32,123,80,111,122,121,99,106,97,
44,32,67,97,197,130,121,65,103,101,110,116,125,32,45,32,
101,119,46,32,100,111,32,122,109,105,97,110,121,44,32,
106,101,115,116,32,122,98,97,108,97,110,115,111,119,97,
110,121,32,91,68,71,93].

Actual line (mind the comment):

gb_trees:from_orddict([{Pos, #ant{pos = Pos, state = model:random_ant_state(Config)}} || Pos <- lists:sort(AntPositions)]). % {Pozycja, CałyAgent} - ew. do zmiany, jest zbalansowany [DG]

Maybe force printing as a string with ~s rather than ~p would help?

@jfacorro
Copy link
Contributor

I think your suggestion might solve the issue. The message for that rule is defined here:

-define(LINE_LENGTH_MSG, "Line ~p is too long: ~p.").

If you have the time please create a PR. Thanks for reporting this!

@jfacorro jfacorro added the bug label Nov 25, 2014
elbrujohalcon pushed a commit that referenced this issue Nov 26, 2014
[Closes #179] Correctly print and quote lines with cyrilic chars.
@jfacorro jfacorro added this to the 0.2.4 milestone Nov 26, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants